EIP-7594: PeerDAS explicit csc integer size #3897
Conversation
|
lgtm from nimbus |
| def test_custody_subnet_count_int_bitlength(spec, custody_subnet_count): | ||
| assert uint8(custody_subnet_count) == custody_subnet_count |
There was a problem hiding this comment.
I think we want to set DATA_COLUMN_SIDECAR_SUBNET_COUNT to uint8 too, and then assert spec.config.DATA_COLUMN_SIDECAR_SUBNET_COUNT == uint8(spec.config.DATA_COLUMN_SIDECAR_SUBNET_COUNT)?
There was a problem hiding this comment.
In this case we are only checking whether a client able read in the config.yaml value from the spec. Would it make more sense to assert that the csc value is uint8 in the enr value instead? This test case on its own probably makes little to no sense.
There was a problem hiding this comment.
These unit tests only cover the helper functions. Pyspec tests don't cover the actual process where the client sets the ENR values.
We have an assert custody_subnet_count <= DATA_COLUMN_SIDECAR_SUBNET_COUNT in get_custody_columns that capped the maximum value of custody_subnet_count.
Co-authored-by: Justin Traglia <[email protected]>
Co-authored-by: Justin Traglia <[email protected]>
There was a problem hiding this comment.
I pushed the commits to set DATA_COLUMN_SIDECAR_SUBNET_COUNT as uint8.
LGTM. Thank you @barnabasbusa!
No description provided.