electra: Add more transition tests #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends fine tunes checks of
upgrade_to_electratests and also introduces tests for new Electra operations triggered right after the fork:DEPOSIT_REQUEST— checks that it yields a new pending depositWITHDRAWAL_REQUEST— test requests full withdrawal and checks that validator exit is initiated, might want to introduce partial withdrawal test in the futureCONSOLIDATION_REQUEST— test requests switch to compounding credentials and checks that is takes effect, we might want to have a test for a fully featured consolidation but this requires a surgery to the tooling to create a state with total active balance enough for consolidation churn to be greater than zeroThis PR also introduces withdrawal and consolidation request helpers. With such helpers the corresponding tests can be refactored to reduce the boiler plate code. But I think it would be better to handle it in a separate PR