Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some nits in the constants/presets sections #4004

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Fix some nits in the constants/presets sections #4004

merged 5 commits into from
Dec 2, 2024

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Nov 6, 2024 •
edited
Loading

  • Add descriptions for the following values:
    • UNSET_DEPOSIT_REQUESTS_START_INDEX
    • FULL_EXIT_REQUEST_AMOUNT
    • COMPOUNDING_WITHDRAWAL_PREFIX
    • MIN_ACTIVATION_BALANCE
    • MAX_EFFECTIVE_BALANCE_ELECTRA
  • Delete unnecessary spaces in some tables.
  • Remove unrendered descriptions in the "State list lengths" table.
    • See that there was no "description" header.
  • Fix description for MAX_DEPOSIT_REQUESTS_PER_PAYLOAD.
    • Essentially replace "deposit receipts" with "deposit requests".

ppopth
ppopth approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@ppopth ppopth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtraglia jtraglia merged commit 8a45549 into ethereum:dev Dec 2, 2024
26 checks passed
@jtraglia jtraglia deleted the nits-in-presets-constants branch December 2, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppopth ppopth ppopth approved these changes

Assignees
No one assigned
Labels
Electra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtraglia @ppopth