Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block hash computation for fork transition tests #4022

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

etan-status
Copy link
Contributor

When overriding execution_requests, have to sync EL payload block hash as the requests are linked to it. Note that this was only caught now because the new request tests were added after the latest fixes applied.

When overriding `execution_requests`, have to sync EL payload block hash
as the requests are linked to it. Note that this was only caught now
because the new request tests were added after the latest fixes applied.
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hwwhww hwwhww merged commit 493d97e into ethereum:dev Nov 28, 2024
26 checks passed
@etan-status etan-status deleted the ef-blockhashfix branch November 28, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants