Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add randomized execution requests in random_block_electra #4032

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Add randomized execution requests in random_block_electra #4032

merged 7 commits into from
Dec 4, 2024

Conversation

KatyaRyazantseva
Copy link
Contributor

This PR adds randomized BeaconBlock.body.execution_requests in random_block_electra.

jtraglia
jtraglia requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A little bug & some nits. I would probably delete some of the whitespace but that's just my personal style.

tests/core/pyspec/eth2spec/test/helpers/multi_operations.py Outdated Show resolved Hide resolved
tests/core/pyspec/eth2spec/test/helpers/multi_operations.py Outdated Show resolved Hide resolved
tests/core/pyspec/eth2spec/test/helpers/multi_operations.py Outdated Show resolved Hide resolved
tests/core/pyspec/eth2spec/test/helpers/multi_operations.py Outdated Show resolved Hide resolved
@KatyaRyazantseva KatyaRyazantseva marked this pull request as ready for review December 4, 2024 03:13
jtraglia
jtraglia approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@jtraglia jtraglia merged commit 72061bb into ethereum:dev Dec 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KatyaRyazantseva @jtraglia