-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "tuple" to "vector" in SSZ spec #794
Conversation
To be done in combination with #777. Also: * Define "fixed-size" and "variable-size" more rigorously * Use `"` vs `'` consistently * Add missing `"`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I know this was already merged, but what is the motivation on using |
Was |
See #777. Basically we want to convey an "ordered fixed-length homogeneous collection of values" in one word. "tuple", "array", "vector", etc. were considered. Python tuples are not homogeneous, and using
|
👍 I think struct is significantly better than vector, I'll create a PR today unless someone is opposed. |
Wait, It's unfortunate there's a bikeshedding surface here. At the end of the day, the spec mostly needs to be consistent and implementers will use whatever terminology is most appropriate for their language. (E.g. in Go it would be |
blarg, ignore me, shouldn't comment on pull requests first thing in the morning before shower and coffee. Long live vectors! |
Align with spec naming, see: ethereum/consensus-specs#794
To be done in combination with ethereum#777. Also: * Define "fixed-size" and "variable-size" more rigorously * Use `"` vs `'` consistently * Add missing `"`
To be done in combination with #777.
Also:
"
vs'
consistently"