Using hash_tree_root
for DepositData
#31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fix #29
Goes along with spec PR #924
How was it fixed?
hash_tree_root
forDepositData
#29 (comment) suggestion, the API now is:def deposit(pubkey: bytes[48], withdrawal_credentials: bytes[32], signature: bytes[96])
minimal_ssz.py
in this repo to verify tree hashing, but I suppose we will either use updatedpy-ssz
or move deposit contract back toeth2.0-specs
.Gas used of the first 10 deposits
Before
After
Increased ~28,000 gas :'(
Cute Animal Picture