Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Withdrawals page updates #9482

Merged
merged 11 commits into from
Feb 16, 2023
Merged

Withdrawals page updates #9482

merged 11 commits into from
Feb 16, 2023

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Feb 12, 2023

Description

  • Few bug patches an fix-ups related to the new /staking/withdrawals page
  • Enables matomo event tracking for internal hash links
  • Adds matomo tracking to contents of withdrawals page, including custom hash link events taking advantage of the modification to the Link component.

Preview link

https://ethereumorgwebsitedev01-withdrawalsv2.gatsbyjs.io/en/staking/withdrawals/

Related Issue

@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 12, 2023

✅ ethereum-org-website-dev deploy preview ready

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wackerow i'm still getting the horizontal scroll on mobile. I do think it has something to do with the hero, possibly the hero image as it looks to be the full width of the overflow. Let me know if you'd like me to take a look. Everything else looks good though.

@wackerow
Copy link
Member Author

wackerow commented Feb 15, 2023

Local:
image
Preview:
image

Removing entire hero doesn't change anything. Removing this Table fixes it (locally at least). Applied whitespace wrap and max width... For some reason it collapses locally, but in the preview build it doesn't and overflows.

@wackerow
Copy link
Member Author

The bugs noted should be patched now... Ready for another review

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @wackerow!

@konopkja could you confirm these Matomo events? Good to go on my end.

@konopkja
Copy link
Contributor

Nice, thanks @wackerow!

@konopkja could you confirm these Matomo events? Good to go on my end.

cant really test events as i dont think they trigger on test env, pls go ahead.

@corwintines corwintines merged commit a4ef594 into dev Feb 16, 2023
@corwintines corwintines deleted the withdrawals-v2 branch February 16, 2023 15:29
@corwintines corwintines mentioned this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal scroll on Withdrawals page
3 participants