fillers/eips/eip4844: Add Blob commitment version kzg to blob versioned hashes. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More tests have been added to verify the functionality. |
spencer-tb
changed the title
marioevz
reviewed
May 11, 2023
spencer-tb
changed the title
|
Tagging the following task: #130
This PR will not be merged until both the spec change ethereum/EIPs#7014 & |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the KZG Version to each blob hash in the current set of 4844 tests.
To give an example, in the fixtures the blob hash will go from:
to
appending the kzg version to the front.
Re: ethereum/EIPs#7009
It's not the most elegant solution but when we move towards a full pytest suite the elegance can be improved!