Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EIP-7069 - EXTCALL with balance and other #755

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Aug 19, 2024

I noticed there was no EXTCALL test with a successful value transfer, so I added one to complete the case from tracker.md

@pdobacz pdobacz changed the title fix(tests): EIP-7069 - test successful EXTCALL with balance new(tests): EIP-7069 - EXTCALL with balance and other Aug 19, 2024
@pdobacz
Copy link
Contributor Author

pdobacz commented Aug 19, 2024

quick update: I found some more low hanging fruit in this department, so I went ahead and pushed some more + a tracker.md update. Sorry about the noise

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few comments.

tests/prague/eip7692_eof_v1/eip7069_extcall/test_calls.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/tracker.md Show resolved Hide resolved
@pdobacz pdobacz requested a review from marioevz August 22, 2024 13:32
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

tests/prague/eip7692_eof_v1/eip7069_extcall/test_calls.py Outdated Show resolved Hide resolved
@marioevz marioevz merged commit ef3e904 into ethereum:main Aug 22, 2024
4 checks passed
@marioevz marioevz deleted the extcall_balance branch August 22, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants