-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): Add multiple exception support to EOF tests #759
Conversation
The These concatenated exceptions are dumped into the fixtures in the form of a pipe-separated string: EOFException.INVALID_VERSION | EOFException.UNDEFINED_INSTRUCTION is dumped into the fixture as: "results": {
"Prague": {
"exception": "EOFException.INVALID_VERSION|EOFException.UNDEFINED_INSTRUCTION",
"result": false
}
} Could this apply to the cases included in this PR? |
I'll definitely look into this. There are many more error cases than are seen in this PR, particualrly in he area of invalid layouts. |
There are some tests that are impossible to express without causing multiple validation exceptions. Clients should be free to expose any of those exceptions. To support this pipe notation for expected exceptions is plumed through the EOF tests and implemented in some tests. Signed-off-by: Danno Ferrin <[email protected]>
29d124c
to
b39f8dd
Compare
The code using EOFExceptions was not expecting the instance or list nomenclature, so I re-booted the PR, and plumbed exception instance or list support through eof_test and updated all the tests Besu will report multiple exceptions for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good so far, just a couple of minor comments. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more comments to make tox happy.
Signed-off-by: Danno Ferrin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll push a commit containing the changelog update and then will merge.
🗒️ Description
There are some tests that are impossible to express without causing
multiple validation exceptions. Clients should be free to expose any of
those exceptions. To support this pipe notation for expected exceptions
is plumed through the EOF tests and implemented in some tests.
🔗 Related Issues
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.