Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EIP-7620: EOFCREATE referencing the same subcontainer twice #809

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

MariusVanDerWijden
Copy link
Member

…e subcontainer twice

🗒️ Description

This test should test that its valid for two EOFCreates to reference the same subcontainer

🔗 Related Issues

@shemnon removed a superfluous case from geth that would fail with this test: MariusVanDerWijden/go-ethereum#56

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@MariusVanDerWijden
Copy link
Member Author

I have not been able to test that this works unfortunately, since I couldn't get the test building to work for eof tests

@shemnon
Copy link
Contributor

shemnon commented Sep 16, 2024

I added a returncontract test and made the eofcreate case focused on just the create.

@MariusVanDerWijden
Copy link
Member Author

Thanks! I just verified that it successfully hits the edge case

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz changed the title tests/prague/eof/eof_create: added test EOFCreate referencing the sam… new(tests): EOF - EIP-7620: EOFCREATE referencing the same subcontainer twice Sep 18, 2024
@marioevz marioevz merged commit be613a0 into ethereum:main Sep 18, 2024
4 checks passed
@holiman
Copy link

holiman commented Sep 25, 2024

Is there any release bundle containing the actual consumable test anywhere? Preferrably all the latest..

@chfast
Copy link
Member

chfast commented Sep 25, 2024

Is there any release bundle containing the actual consumable test anywhere? Preferrably all the latest..

https://github.com/ethereum/execution-spec-tests/releases/tag/eip7692%40v1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants