Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fw): EOF - Accept initcode_prefix on EOF Container.Init #819

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

marioevz
Copy link
Member

🗒️ Description

Adds initcode_prefix parameter to Container.Init in order to add executable bytecode that must be appended before EOFCREATE[0](0, 0) in the resulting container's code section.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:bug Something isn't working scope:fw Scope: Framework (evm|tools|forks|pytest) labels Sep 18, 2024
@marioevz marioevz requested a review from winsvega September 18, 2024 21:39
Copy link
Contributor

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what will it look like if we mstore some bytes in init code prefix?

@marioevz
Copy link
Member Author

And what will it look like if we mstore some bytes in init code prefix?

Not really, it will just append bytecode to execute before returning the contract, for example an SSTORE if you would like to store something during contract initialization.

@marioevz marioevz merged commit 12c0087 into main Sep 19, 2024
7 checks passed
@marioevz marioevz deleted the initcode-prefix-eof branch September 19, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants