-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): EOF - EIP-4750: Stack validation in CALLF #889
Conversation
Add a test to cover cases where stack would not overflow but CALLF stack reservation rules would cause a revert. Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments. Do we need to also update eof_tracker.md
? I'm not sure but maybe Max stack size (1024) in CALLF-ed function
was covering this case, please double check though, I didn't analyze it
tests/osaka/eip7692_eof_v1/eip4750_functions/test_callf_execution.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7692_eof_v1/eip4750_functions/test_callf_execution.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Added another tests to check CALLF when stack is at max ("rule #4") - by EIP this should revert, but there are ways it would succeed without the check, so we need to do one of those ways and then test it. |
Signed-off-by: Danno Ferrin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
ποΈ Description
Add a test to cover cases where stack would not overflow but CALLF stack
reservation rules would cause a revert.
π Related Issues
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.