Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM push behaviour #446

Closed
obscuren opened this issue Mar 10, 2015 · 0 comments
Closed

VM push behaviour #446

obscuren opened this issue Mar 10, 2015 · 0 comments
Assignees
Milestone

Comments

@obscuren
Copy link
Contributor

pushN currently, when overflowing, prepends bytes rather than appending them. While this can't cause any consensus failure it should append the bytes for consistency.

For example

0x80 // PUSH32
0x01

should push 0x0100000000000000000000000000000000000000000000000000000000 next this program will run in to 0x00 (STOP).

@obscuren obscuren self-assigned this Mar 10, 2015
@obscuren obscuren added this to the Frontier milestone Mar 10, 2015
ngtuna pushed a commit to ngtuna/tomochain that referenced this issue Feb 22, 2019
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Nov 12, 2021
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Jan 6, 2023
* use atomic pointer

* golang version

* golang version

* go1.19

* linters

* Bump golangci-lint

* linters

* linters

* linters after merge

* generic logger

* generic logger

* logger

* logger

* linters

* bump toml

* linters1

* linters

* linters

* linter

* linter

* linters

* linters

* linters
Eduard-Voiculescu pushed a commit to streamingfast/go-ethereum that referenced this issue Dec 20, 2024
…ethereum#446)

* core: Move blockchain head verification after possible rewind

If the blockchain needs a rewind due to a config change, it makes more
sense to first perform that rewind and only then check the chain head's
validity. The change in config might cause the loaded chain's head to be
invalid before the rewind.

* log configs at startup

* fix logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant