Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to display Mist menu bar on linux #129

Merged
merged 4 commits into from
Sep 19, 2014
Merged

Fix to display Mist menu bar on linux #129

merged 4 commits into from
Sep 19, 2014

Conversation

JosephGoulden
Copy link
Contributor

Hi. I'm running Mist on Linux Mint. Looks good but the menu bar was not shown until I made this change.

@obscuren
Copy link
Contributor

Hey, thanks or the PR but please have a look here:

http://qt-project.org/doc/qt-5/qml-qtquick-controls-applicationwindow.html#menuBar-prop

menuBar is a property of the ApplicationWindow which should create a native menu bar (OS X, top screen, Window/Linux top of app it self).

Could you pop in a screenshot with the issue?

@JosephGoulden
Copy link
Contributor Author

This is what it looks like for me with no changes.

mist

The change I made is the same as the example code in the link you sent. Honestly though, I'm new to Qt so might be missing something.

@obscuren
Copy link
Contributor

I'm only just seeing now that I'm the one that forgot to add the menuBar and that you've actually fixed it ... shame on me. Will merge asap! Thanks

@obscuren obscuren merged commit d953415 into ethereum:develop Sep 19, 2014
stevenroose pushed a commit to stevenroose/go-ethereum that referenced this pull request Sep 14, 2017
…provements

docs, raft, core: general readability improvements
ngtuna added a commit to ngtuna/tomochain that referenced this pull request Aug 10, 2018
Fixed div by zero for calculate reward.
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Aug 13, 2021
spencer-tb pushed a commit to spencer-tb/go-ethereum that referenced this pull request May 11, 2023
atenjin pushed a commit to alt-research/go-ethereum that referenced this pull request Apr 4, 2024
…e_min_suggested_fee

Decrease GPO min suggested fee & make it configurable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants