Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis, build, consensus: drop support for Go 1.7 #16207

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Feb 27, 2018

This PR drops support for building with Go 1.7. The reasons are:

  • Starting with the release of Go 1.10, the last supported Go version for security fixes is 1.9 (not even 1.8) https://golang.org/doc/devel/release.html#policy . As such, it's actually advisable not to support old Go versions for us.
  • Go 1.8 introduces certain testing helpers that @nonsense and the Swarm team rely on, so it's simpler to drop 1.7 than to keep patching around the missing features.
  • Go 1.7 does not support detecting Bit Manipulation Instruction sets for the CPUs, so crypto libraries either need patches for 1.7, cannot use advanced CPU features, or will simply fail to build (e.g. cloudflare bn256 core/vm, crypto/bn256: switch over to cloudflare library #16203).

@karalabe karalabe added this to the 1.8.2 milestone Feb 27, 2018
@karalabe karalabe requested review from fjl and nonsense February 27, 2018 16:31
Copy link
Member

@nonsense nonsense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit 8f43c97 into ethereum:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants