Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add an option to stop geth once in sync #16690

Closed
wants to merge 1 commit into from

Conversation

glaksmono
Copy link

@glaksmono glaksmono commented May 6, 2018

The addition of a new flag that would stop and exit when the chain has been caught up.

Reference Issue: #16400

Discussion

  1. I'm figuring out which part of the code that identifies the chain has been synced here

Correct me if I'm wrong, but I think the Completed State should be at the api.go?

I needed to breakdown DoneEvent vs. FailedEvent in the func (api *PublicDownloaderAPI) eventLoop() to be like the following:

			case DoneEvent:
                                 // Is this the Done state?
				notification = false
			case FailedEvent:
				notification = false

If so, I'd apply the fix and re-create the PR

  1. I've been trying to test and find the completed state for geth to exit, but then I read this: Block number is always zero with fast syncmode #16411 (comment) - Thoughts about it?

@glaksmono glaksmono requested a review from karalabe as a code owner May 6, 2018 13:39
@GitCop
Copy link

GitCop commented May 6, 2018

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 1ae8758
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

@glaksmono glaksmono changed the title [go-eth-16400] Add an option to stop geth once in sync [in progress] [go-eth-16400][in progress] Add an option to stop geth once in sync May 6, 2018
@glaksmono glaksmono changed the title [go-eth-16400][in progress] Add an option to stop geth once in sync [WIP] Add an option to stop geth once in sync May 11, 2018
@glaksmono glaksmono closed this May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants