[WIP] Add an option to stop geth once in sync #16690
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of a new flag that would stop and exit when the chain has been caught up.
Reference Issue: #16400
Discussion
Correct me if I'm wrong, but I think the Completed State should be at the
api.go
?I needed to breakdown
DoneEvent
vs.FailedEvent
in thefunc (api *PublicDownloaderAPI) eventLoop()
to be like the following:If so, I'd apply the fix and re-create the PR
completed
state forgeth
to exit, but then I read this: Block number is always zero with fast syncmode #16411 (comment) - Thoughts about it?