p2p/simulation: move connection methods from swarm/network/simulation #18305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor was done as the second part of our current network testing efforts; as outlined in #1038. Co-authored-by: Elad Nachmias <[email protected]>
frncmx
requested review from
holisticode,
janos,
acud and
zelig
as code owners
frncmx
requested review from
nolash
and removed request for
holisticode and
acud
|
I did not yet want to open this on upstream. Sry. |
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor was done as the second part of our current network
testing efforts; as outlined in ethersphere/swarm#1038.
Co-authored-by: Elad Nachmias [email protected]