Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: tune flaky tests that error in travis occasionally #18508

Merged
merged 2 commits into from
Jan 23, 2019

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jan 23, 2019

This PR fixes a couple of testcases that from time to time error on travis.

--- FAIL: TestInvalidNumberAnnouncement63 (0.06s)
    fetcher_test.go:628: peer with invalid numbered announcement not dropped

--- FAIL: TestEmptyWorkEthash (1.06s)
    worker_test.go:228: new task timeout

--- FAIL: TestReporter (0.04s)
    reporter_test.go:69: Expected counter to be 12, but is 0

--- FAIL: TestProtocolHook (0.02s)
    protocol_test.go:273: Expected peer ID to be set correctly, but it is not

Mostly it's timeouts, but there's one change in protocol_test.go that is changed 'semantically'.
The test expects a certain order of events, and sometimes it seems to arrive in a different order. I changed the test to accept any order, but I'm not sure if that is a false positive or an actual error that should be fixed somewhere.

The test comes from #17951 by @holisticode , PTAL

@holiman holiman requested a review from janos as a code owner January 23, 2019 13:30
@holiman holiman merged commit dc43ea8 into ethereum:master Jan 23, 2019
@holiman holiman deleted the travis_fixes branch January 23, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants