-
Notifications
You must be signed in to change notification settings - Fork 20.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some panics to be handled on adversarial input #196
Conversation
Uses of ethutil.Decode (and hopefully also ethutil.Value) will be replaced by package rlp. I'm working on it right now. We are also working on a new peer to peer networking layer in package p2p (see #155). It will be a lot less racy. |
Ok awesome. Am looking forward to it. Just trying to avoid peers being able to crash clients by sending bad data. As for the txpool, it's simply missing a sig check (rather than being rlp related). I will add the test to my other PR fixing it (#195), I simply wanted to avoid duplicating the |
Please re-open if you want to work in the new rlp decoder/encoder |
…es-validation Mutable resources with ENS contenthashes and access validation
…ter-20201001 Merge/foundation master 20201001
* make BLOCKHASH return only last blockhash * fix * small fix
…n-conditional Support eth_sendRawTransactionConditional
params: add note about Delta, update protocol version to indicate Delta pre-release support
No need to merge this. Probably we should start an
Adversary
folder in theTests
directory and begin to standardize this sort of thing. But here I'm pointing out thatThese are important because they are called more or less directly after receiving raw bytes from peers.