Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/gasprice, internal/ethapi, miner: minor feehistory fixes #23178

Merged
merged 1 commit into from
Jul 9, 2021
Merged

eth/gasprice, internal/ethapi, miner: minor feehistory fixes #23178

merged 1 commit into from
Jul 9, 2021

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Jul 8, 2021

This PR contains a few fixes to the feeHistory code, which was merged a bit prematurely:

  • The snapshotReceipts in the miner are copied to avoid a data race.
  • The API return fields are lower cased and the rewards omitted if not requested.
  • Error returns are modified a bit to be consistent with Go styles and some contextual infos are added.
  • Naked returns are removed since they made the code very hard to follow.
  • Other nits and bits.

@karalabe karalabe added the london label Jul 8, 2021
@karalabe karalabe added this to the 1.10.5 milestone Jul 8, 2021
@karalabe karalabe requested a review from holiman as a code owner July 8, 2021 07:01
rjl493456442
rjl493456442 approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks, lgtm

eth/gasprice/feehistory.go Outdated Show resolved Hide resolved
zsfelfoldi
zsfelfoldi approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@zsfelfoldi zsfelfoldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comment about result field names

internal/ethapi/api.go Show resolved Hide resolved
@karalabe karalabe merged commit 9624f92 into ethereum:master Jul 9, 2021
@gzliudan gzliudan mentioned this pull request May 17, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
6a146cd
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
7dba17b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
ef4e876
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
f7af1f3
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
93410c8
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
d5abde7
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
9b01bf9
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
0081713
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
6597451
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
a8b69ab
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
cecef1b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
548579d
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
2c5ef87
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
378bc13
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
4c54721
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
2d861eb
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
791f415
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
6ee7ffb
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
ea12b12
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
9cae6cd
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
0d288ab
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
72c7ef0
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
d870542
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
f62ad53
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 29, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
175542f
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 30, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
153fdd1
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
55c5b9d
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
2949225
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024
@gzliudan
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
5766ca4
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Nov 13, 2024
@gzliudan @wanwiset25
eth/gasprice, internal/ethapi: minor feehistory fixes (ethereum#23178)
1c473c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsfelfoldi zsfelfoldi zsfelfoldi approved these changes

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@holiman holiman Awaiting requested review from holiman holiman is a code owner

Assignees
No one assigned
Labels
london
Projects
None yet
Milestone
1.10.5
Development

Successfully merging this pull request may close these issues.
3 participants
@karalabe @rjl493456442 @zsfelfoldi