core: fix txs reindex after reindex from ancients crashed #25595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ucwong
requested review from
karalabe,
holiman and
rjl493456442
as code owners
fjl
approved these changes
Aug 26, 2022
fjl
changed the title
| // indices in the background. | ||
| frozen, _ := bc.db.Ancients() | ||
| if frozen > 0 { | ||
| txIndexBlock = frozen |
There was a problem hiding this comment.
It's not correct, previously we will only re-init the ancient blocks in this special corner case where state is empty but ancient store it not. With this change we will re-init the ancient blocks all the time.
I will try to figure out a proper solution to fix it.
plus superseded by #25723 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once tx reindex crashing, it will not repair the txs index again