Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read most protocol params from common/params.json #623

Conversation

Gustav-Simonsson
Copy link

  • Add params package with exported variables generated from
    github.com/ethereum/common/blob/master/params.json
  • Use params package variables in applicable places
  • Add check for minimum gas limit in validation of block's gas limit
  • Remove common/params.json from go-ethereum to avoid
    outdated version of it

@@ -13,45 +14,10 @@ var (
GasSlowStep = big.NewInt(10)
GasExtStep = big.NewInt(20)

GasStorageGet = big.NewInt(50)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could have saved yourself a lot of trouble by changing just the assignment :-)

obscuren added a commit that referenced this pull request Apr 1, 2015
…om_common_params

Read most protocol params from common/params.json
@obscuren obscuren merged commit 219d94c into ethereum:develop Apr 1, 2015
* Add params package with exported variables generated from
  github.com/ethereum/common/blob/master/params.json
* Use params package variables in applicable places
* Add check for minimum gas limit in validation of block's gas limit
* Remove common/params.json from go-ethereum to avoid
  outdated version of it
ngtuna pushed a commit to ngtuna/tomochain that referenced this pull request Aug 21, 2019
…n-snapshot-return-wrong-signers-data

Fix ethereum#611 refactor code
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this pull request Jan 20, 2022
* Write COMMIT_SHA to /version.txt in Docker container

* Fix Makefile source tracking for vendor/github.com/celo-org/bls-zexe/bls/target/release/libbls_zexe.a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants