Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients/lighthouse-bn: Add Optimistic Sync Options + Trusted Peers with Static Keys #604

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

marioevz
Copy link
Member

Adds client support for HIVE_ETH2_SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY setting:

  • SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY is set in config.yaml
  • --safe-slots-to-import-optimistically is set as parameter to the same value

@marioevz marioevz changed the title clients/lighthouse-bn: Add SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY clients/lighthouse-bn: Add Optimistic Sync Options + Trusted Peers with Static Keys Aug 17, 2022
@marioevz
Copy link
Member Author

Hi @pawanjay176, I added static keys for at least 5 nodes.
Let me know if this looks ok, thanks!

@pawanjay176
Copy link
Contributor

@marioevz we are very close to merging a PR (sigp/lighthouse#3428) which might make the trusted-peers hack redundant. I'm trying to test out the optimistic sync hive test cases with that PR but the tests are ending prematurely for some reason.

I'll try to fix it up locally and let you know if the static peers is indeed required.

@marioevz
Copy link
Member Author

Hey @pawanjay176, I guess it wouldn't hurt to have this fix merged and then remove it in a subsequent PR if necessary.
Could we go ahead and merge since this is required for another PR (#637) ?
Thanks.

@pawanjay176
Copy link
Contributor

Yep, sgtm.

@marioevz marioevz merged commit 1d75f5d into ethereum:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants