simulators/ethereum/engine: Withdrawals Test Suite #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
force-pushed
the
engine-withdrawals-2
branch
from
5ec12a3 to
10c3830
Compare
This was referenced Jan 2, 2023
|
Build for This doesn't seem right, I'm not sure why a replace within a submodule could affect the root module in a workspace, do you know if this behavior is expected @fjl ? Any pointers would be appreciated, since I've tried many workarounds to this error and I could not get it fixed. |
marioevz
force-pushed
the
engine-withdrawals-2
branch
from
07c40e0 to
62a69bf
Compare
|
This was merged in #676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft of withdrawals tests.
At the moment it simply makes the required changes to the CLMocker to be able to send the new versions of the Engine API methods that support withdrawals.
More test cases need to be added.