Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simulators/eth2: Common Library #667

Closed
wants to merge 4 commits into from
Closed

simulators/eth2: Common Library #667

wants to merge 4 commits into from

Conversation

marioevz
Copy link
Member

Coalesce common code between eth2 simulators into a library that allows code reuse.

@marioevz marioevz force-pushed the eth2-common branch 2 times, most recently from c466c25 to 56ff624 Compare December 30, 2022 20:49
@marioevz marioevz marked this pull request as ready for review December 30, 2022 21:06
This was referenced Jan 2, 2023
Closed
Closed
@timbeiko timbeiko mentioned this pull request Jan 11, 2023
Closed
@marioevz marioevz marked this pull request as draft January 19, 2023 22:10
@marioevz
Copy link
Member Author

Updated to use latest geth version, which requires go.mod replace.

Changing to draft because merging would break other simulators until either:

  • Withdrawals' changes are merged
  • We use go.mod replace on the modules/simulators where the replace is breaking stuff.

@fjl fjl mentioned this pull request Jan 23, 2023
Merged
@fjl
Copy link
Collaborator

fjl commented Jan 23, 2023

These changes were merged as part of #681

@fjl fjl closed this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marioevz @fjl