Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fee Recipient API #24
Fee Recipient API #24
Changes from 17 commits
c9487c3
6c4e813
166e8ae
fd1e33c
ffaa666
422d2eb
749917b
160a15d
08b323b
c058c12
447137a
82580b3
d9bbe54
4500f6f
4f9eb94
aa10025
9b3f95c
c094bd1
2063d06
c32e9aa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so i think we go with 202, description "successfully updated", and no content.
The 200 then wont be used for the POST. I've said this in a couple of comments but highlighting the actual code for review here (sorry if it sounds like I'm nagging, but this is arguably the best actual place to comment for it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, appreciate the comments. I just updated it, how does it look now?
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the bit i think, if we just change this in the current PR to be
/eth/v1/validator/{pubkey}/feerecipient
I think we leave the change i was talking about easy without making people move from the one we do here...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh i misunderstood then, ok i'll follow that then and change it to under validator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EthAddress
- missed capital ~A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated