-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Berlin timing #248
Comments
Since Yolo v3 is still in very active movement (just restarted three days ago triggered by @holiman) I think it is safe to give this a minimal extension estimate (so: not a timeline but just an estimate how this is minimally delayed based on the facts right now):
=> Minium Just as some calculation for orientation (I find this personally still a bit (too) ambitious, but might be doable if we focus). |
Ok, like this?
|
Yes, when seeing this and going a step back I think this might even be a good balance on timing needs so that we are not getting too close to #245 and a somewhat realistic timelime for implementation if everyone focuses. |
Added to the agenda, @q9f ! |
@holgerd77 re:
Why do we want that before forking the testnets? IIRC, we've used the yolo networks in the past to just test that clients can sync to each other, and we've fuzzed them a bit with transactions. I don't think this needs to take 2 weeks. Re:
I think maybe we can do something like set the fork block once all clients sync to each other, for 3 weeks in the future. WDYT? IMO 1 week to put out a release and distribute it after a bug has been found is short, so I think the best we can do is plan for the "happy case" where clients are all in sync, and then have clients put out a release with a block 2-3 weeks in the future. |
I am always a fan of planning for the "non-happy case". 😄 In the JavaScript team we perceive A buffer has also the advantage that it reduces the cost of additional delay planning - especially for such short periods like 2-3 weeks or so. We already had this often in the past and there is a substantial coordination effort here in case (additional calls, new client releases, (public) communication), also to note a not-so-optimal outer perception if there are too many delays. But at the end I am also fine with the happy-case planning and the 3-weeks-in-the-future date setting for the first testnet fork. 🙂 |
FWIW, my preferred approach would be something like Scenario C, without Kovan happening in parallel, given OE will deal with it post-Berlin (link). So it would look something like:
This gets us on mainnet 1 week earlier, and will give us a ~2 month window between Berlin and London hitting mainnet. |
Based on the discussion in #245, another proposal may be to have the first testnet fork sooner. All clients are already syncing on YOLOv3, so we could do something like:
This gives a longer delay between Berlin and London (say London happened mid-July, that's a full 3 months), and it also gives 3 weeks from now for the first testnet to fork. |
Potential block numbers:
Math
|
Diff bomb: https://eips.ethereum.org/EIPS/eip-3238 |
TBH I am not a fan of closing this already, can't we keep this open as a reference PR until all dates have been executed upon (or what would be an alternative go-to place to look up these numbers)? There will also likely be (some) continued need for discussions around block numbers, additional comments on timeframe concretizations, and the like. All this would be suited to happen here. |
updated PRs if we consider this "final" I don't mind closing this, but I agree we should keep the London conversation open. |
Re-opened for now. Let's consider the blocks final, and close the issue once Berlin is live 👍 |
Ropsten forks when this comment is 4.98 days old. |
This is in less than two days now. Since go-ethereum hasn't even got a release out with the fork activations and a removed What's with the other fork numbers, should everything be postponed by a week here? |
ACD call on Friday say they want to go ahead with the fork as scheduled originally, so that's what we've went with. |
Also, Geth v1.10.1 was released just after you made your comment :D https://github.com/ethereum/go-ethereum/releases/tag/v1.10.1 |
@karalabe thanks, that's nice that you confirmed here. 🙂 |
Yep, confirming we agreed to keep the fork blocks as in this comment on ACD. We'll also have a blog post out today (hopefully!) with the details of the upgrade. |
Update, these are the final numbers:
Original post/conversation below this line.
I think we should discuss Berlin timing again because nothing materialized since the last ACD and this should have higher priority than the London timing. Copy-pasta from discord:
This is already next week though... can run the numbers again but at some point we would have to make a decision instead of pushing this from meeting to meeting.
The text was updated successfully, but these errors were encountered: