-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ethereum Core Devs Meeting 114 Agenda #321
Comments
I suggest to talk about more general DOS protection and decoupling worst and average performance when it comes to determining safe gas limit, as I described here: https://ethresear.ch/t/a-third-way-coordinating-the-gas-limit/9297/2 |
Hi guys, I would like to table this draft EIP (regarding building a block |
@g11in @pipermerriam if you just want to share the EIP with core devs and give a summary, we can definitely do it on this call. It is still very early to talk about inclusion in future upgrades given that London is still being sorted out and we still have not decided/committed to another "feature upgrade" before the merge. If you want it added to the agenda as a discussion item, just confirm here and I'll put it towards the end 👍 |
Yes, low priority, but having it at the end of the call just to float the EIP and get preliminary feedback would be nice. |
Added, @pipermerriam ! |
I think we should discuss ethereum/go-ethereum#22963 TLDR; 1559-transactions can be arbitrarily large, without the large-ness having an effect on the tx cost for the sender, nor the gas used in the block. The only practical limits are on the implementation side: the 10Mb rlp packet size limit, and whatever limits used in various pool implementations. As far as the consensus-engine goes, a 12MGas block can become hundreds of megabytes. Or petabytes, whatever. I don't think it's very hard to fix, e..g by limiting the fields to 64 or 256 bits, but I do think we need a last-minute change to 1559. Suggestion: require(maxFeePerGas < 2^256) # Prevent impossibly large numbers
require(maxPriorityFeePerGas < 2^256) # Prevent impossibly large numbers
require(maxFeePerGas >= maxPriorityFeePerGas) # Makes sense that the total is larger than a part thereof
require(sender.balance >= gasLimit * maxFeePerGas) # The sender needs to be able to cover the full max resources he's claiming Where the fourth rule is the most "controversial". I'm ambivalent myself. |
@holiman Does this only affect these two new fields and are there checks already in place for existing fields like |
The important aspect are the new fields. The other fields are already capped in practive, e.g. gasLimit is bound by block gas limit, and gasPrice is bound since It's only with these new fields that we have the possibility of a not-used arbitrary large integer hanging around. |
@holiman added to the agenda 👍 |
Can we mention the 1559 Gas API Breakout call? Date/Time: Friday, June 4 at 14:00 UTC (10:00 ET) |
Closed in favor of #330 |
…ds (#2338) based on: ethereum/pm#321 (comment) Signed-off-by: Ratan Rai Sur <[email protected]>
…ds (hyperledger#2338) based on: ethereum/pm#321 (comment) Signed-off-by: Ratan Rai Sur <[email protected]>
…ds (hyperledger#2338) based on: ethereum/pm#321 (comment) Signed-off-by: Ratan Rai Sur <[email protected]>
ACD 114
Meeting Info
Agenda
The text was updated successfully, but these errors were encountered: