Deploy And Run Transactions Browser Tests #2707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioedeveloper
force-pushed
the
run-deploy-e2e-tests
branch
from
afa373c
to
78c98d2
Compare
yann300
reviewed
Apr 8, 2020
| .click('*[data-id="Deploy - transact (not payable)"]') | ||
| .switchBrowserTab(2) | ||
| .waitForElementPresent('.transaction-status--unapproved') | ||
| .click('.transaction-status--unapproved') |
There was a problem hiding this comment.
could you give some context why we need to click on .transaction-status--unapproved' ?
There was a problem hiding this comment.
.transaction-status--unapproved is the class of the dom element for an unapproved transaction.
On click, it opens an approval/confirmation page in metamask.
yann300
force-pushed
the
run-deploy-e2e-tests
branch
from
93d7f9f
to
a3ab84f
Compare
yann300
approved these changes
Apr 17, 2020
Deploy And Run Transactions Browser Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/ethereum/remix-ide/issues/2576