refactored debuggerUI #2866
Merged
refactored debuggerUI #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LianaHus
commented
May 28, 2020
LianaHus
commented
- using SourceHighlight fix https://github.com/ethereum/remix-ide/issues/2834
- removed self
yann300
reviewed
May 28, 2020
src/app/tabs/debugger/debuggerUI.js
Outdated
| } | ||
| }) | ||
|
|
||
| this.debugger.event.register('debuggerUnloaded', self.unLoad.bind(this)) | ||
| this.debugger.event.register('debuggerUnloaded', () => unLoad) |
There was a problem hiding this comment.
@yann300 pushed another commit
LianaHus
force-pushed
the
debugerHighlight
branch
from
d8be520
to
5d698c2
Compare
LianaHus
force-pushed
the
debugerHighlight
branch
from
b0aac7a
to
8da1d9c
Compare
yann300
reviewed
May 30, 2020
src/app/tabs/debugger-tab.js
Outdated
| @@ -71,7 +71,7 @@ class DebuggerTab extends ViewPlugin { | |||
| } | |||
|
|
|||
| deactivate () { | |||
| this.debuggerUI.unLoad() | |||
| this.debuggerUI.deletHighlights() | |||
yann300
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.