Issue warning when using deprecated SELFDESTRUCT

ethereum · Jan 19, 2023 · 663d66d · 663d66d
1 parent c195782
commit 663d66d
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 0 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -19,6 +19,7 @@ Compiler Features:
  * SMTChecker: Make ``z3`` the default solver for the BMC and CHC engines instead of all solvers.
  * Parser: More detailed error messages about invalid version pragmas.
  * Removed support for the ``solidity-upgrade`` tool.
+ * TypeChecker: Warn when using deprecated bulitin ``selfdestruct``.
 
 
 Bugfixes:

diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp
@@ -3642,6 +3642,12 @@ bool TypeChecker::visit(Identifier const& _identifier)
 				_identifier.location(),
 				"\"suicide\" has been deprecated in favour of \"selfdestruct\"."
 			);
+		else if (_identifier.name() == "selfdestruct" && fType->kind() == FunctionType::Kind::Selfdestruct)
+			m_errorReporter.warning(
+				5159_error,
+				_identifier.location(),
+				"\"selfdestruct\" has been deprecated."
+			);
 	}
 
 	if (

diff --git a/test/libsolidity/syntaxTests/nameAndTypeResolution/430_bare_selfdestruct.sol b/test/libsolidity/syntaxTests/nameAndTypeResolution/430_bare_selfdestruct.sol
@@ -2,4 +2,5 @@ contract C {
     function f() pure public { selfdestruct; }
 }
 // ----
+// Warning 5159: (44-56): "selfdestruct" has been deprecated.
 // Warning 6133: (44-56): Statement has no effect.
diff --git a/test/libsolidity/syntaxTests/types/address/address_nonpayable_selfdestruct.sol b/test/libsolidity/syntaxTests/types/address/address_nonpayable_selfdestruct.sol
@@ -4,4 +4,5 @@ contract C {
     }
 }
 // ----
+// Warning 5159: (56-68): "selfdestruct" has been deprecated.
 // TypeError 9553: (69-70): Invalid type for argument in function call. Invalid implicit conversion from address to address payable requested.
diff --git a/test/libsolidity/syntaxTests/types/address/address_payable_selfdestruct.sol b/test/libsolidity/syntaxTests/types/address/address_payable_selfdestruct.sol
@@ -4,3 +4,4 @@ contract C {
     }
 }
 // ----
+// Warning 5159: (64-76): "selfdestruct" has been deprecated.
diff --git a/test/libsolidity/syntaxTests/viewPureChecker/builtin_functions.sol b/test/libsolidity/syntaxTests/viewPureChecker/builtin_functions.sol
@@ -19,3 +19,4 @@ contract C {
     receive() payable external {}
 }
 // ----
+// Warning 5159: (122-134): "selfdestruct" has been deprecated.
diff --git a/test/libsolidity/syntaxTests/viewPureChecker/builtin_functions_view_fail.sol b/test/libsolidity/syntaxTests/viewPureChecker/builtin_functions_view_fail.sol
@@ -20,6 +20,7 @@ contract C {
     }
 }
 // ----
+// Warning 5159: (201-213): "selfdestruct" has been deprecated.
 // TypeError 8961: (52-77): Function cannot be declared as view because this expression (potentially) modifies the state.
 // TypeError 8961: (132-153): Function cannot be declared as view because this expression (potentially) modifies the state.
 // TypeError 8961: (201-228): Function cannot be declared as view because this expression (potentially) modifies the state.
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,4 +4,5 @@ contract C { @@
         }
     }
     // ----
+    // Warning 5159: (56-68): "selfdestruct" has been deprecated.
     // TypeError 9553: (69-70): Invalid type for argument in function call. Invalid implicit conversion from address to address payable requested.