Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE when emitting event from another contract #14434

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

nikola-matic
Copy link
Collaborator

Fixes: #14430

@nikola-matic nikola-matic added this to the 0.8.22 milestone Jul 20, 2023
@nikola-matic nikola-matic force-pushed the fix-natspec-event-ice branch 3 times, most recently from 3f29cde to e5018bf Compare July 20, 2023 11:32
Changelog.md Outdated Show resolved Hide resolved
libsolidity/interface/Natspec.cpp Outdated Show resolved Hide resolved
@nikola-matic nikola-matic marked this pull request as ready for review July 21, 2023 08:57
@nikola-matic nikola-matic requested a review from cameel July 21, 2023 08:57
@nikola-matic nikola-matic self-assigned this Jul 21, 2023
@nikola-matic nikola-matic force-pushed the fix-natspec-event-ice branch from 00e786f to de4e1f3 Compare July 21, 2023 09:04
@nikola-matic nikola-matic force-pushed the fix-natspec-event-ice branch from de4e1f3 to 1286081 Compare July 21, 2023 14:25
@cameel cameel force-pushed the fix-natspec-event-ice branch from 1286081 to 964bdc7 Compare July 21, 2023 19:49
@cameel cameel merged commit 548b033 into develop Jul 21, 2023
@cameel cameel deleted the fix-natspec-event-ice branch July 21, 2023 21:18
@frangio
Copy link
Contributor

frangio commented Jul 24, 2023

Is this going to be released as soon as possible or whenever the rest of planned items for 0.8.22 are done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

ICE during Natspec generation when emitting an event from a foreign contract or interface
3 participants