Purge using namespace std from libsolidity/analysis #14488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-matic
force-pushed
the
purge-using-namespace-std-from-libsolidity-analysis
branch
from
9133683
to
de1a017
Compare
ekpyron
approved these changes
Aug 14, 2023
Comment on lines
27
to
+28
| libsolc/* | ||
| libsolidity/analysis/* |
There was a problem hiding this comment.
Looks like a tabs-vs-spaces inconsistency here.
There was a problem hiding this comment.
Yeah, added that one with vim - I'll merge, and then resolve it in the other PR, since I'll have to rebase it anyway.
nikola-matic
deleted the
purge-using-namespace-std-from-libsolidity-analysis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #14403