Remove remaining artifacts of dynamically loading Z3. #15537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekpyron
force-pushed
the
cleanoutDynamicZ3Stuff
branch
from
7977915
to
c01e62b
Compare
ekpyron
commented
Oct 22, 2024
|
|
||
| .. note:: | ||
|
|
||
| Solidity can optionally use other solvers, namely ``cvc5`` and ``Eldarica``, | ||
| but their presence is checked only at runtime, they are not needed for the build to succeed. | ||
| The emscripten builds require Z3 and will statically link against it instead. |
There was a problem hiding this comment.
It actually is a hard requirement for emscripten now. I'm actually wondering if we should make it optional again there, but if we want to do that, we can do it separately (and custom emscripten builds ought to be very rare anyways)
ekpyron
force-pushed
the
cleanoutDynamicZ3Stuff
branch
from
c01e62b
to
457bed6
Compare
matheusaaguiar
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some leftovers from #15252