Add statemutability field to ABI #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
reviewed
Aug 14, 2017
Changelog.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| ### 0.4.16 (unreleased) | |||
|
|
|||
| Features: | |||
| * ABI: Include new field ``statemutability`` with values ``view``, ``nonpayable`` and ``payable``. | |||
There was a problem hiding this comment.
More specifically: json-ABI. Also, why is pure not a valid option? Should we name it stateaccess? Or stateaccessrestrictions?
There was a problem hiding this comment.
Argh, sorry, of course because pure is not yet part of this PR...
There was a problem hiding this comment.
Going to add pure in a separate PR.
chriseth
reviewed
Aug 14, 2017
libsolidity/ast/ASTEnums.h
Outdated
| // How a function can mutate the EVM state. | ||
| enum class StateMutability { View, NonPayable, Payable }; | ||
|
|
||
| inline std::string stateMutabilityToString(StateMutability const& _stateMutability) |
There was a problem hiding this comment.
C++ has nicely-usable overloads, we can call this just toString.
There was a problem hiding this comment.
I think this part of the review belongs to #2722.
chriseth
reviewed
Aug 14, 2017
libsolidity/ast/Types.h
Outdated
| @@ -985,6 +982,7 @@ class FunctionType: public Type | |||
| /// @returns true if the ABI is used for this call (only meaningful for external calls) | |||
| bool isBareCall() const; | |||
| Kind const& kind() const { return m_kind; } | |||
| StateMutability const& stateMutability() const { return m_stateMutability; } | |||
There was a problem hiding this comment.
It is probably better to return by value.
There was a problem hiding this comment.
Addressed this in the real PR.
chriseth
approved these changes
Aug 14, 2017
axic
changed the title
axic
force-pushed
the
statemutability-abi
branch
from
b9db2ef to
db10c9f
Compare
|
Need to update tests. |
axic
force-pushed
the
statemutability-abi
branch
2 times, most recently
from
c0baac5 to
3cbf446
Compare
axic
commented
Aug 15, 2017
test/libsolidity/SolidityABIJSON.cpp
Outdated
| @@ -548,12 +561,44 @@ BOOST_AUTO_TEST_CASE(constructor_abi) | |||
| } | |||
| ], | |||
| "payable": false, | |||
| "statemutability" :"nonpayable", | |||
axic
commented
Aug 15, 2017
test/libsolidity/SolidityABIJSON.cpp
Outdated
| } | ||
| ], | ||
| "payable": true, | ||
| "statemutability" :"payable", |
axic
force-pushed
the
statemutability-abi
branch
from
3cbf446 to
557e379
Compare
|
@chriseth ready to merge |
axic
force-pushed
the
statemutability-abi
branch
2 times, most recently
from
8b1efdd to
56a7881
Compare
axic
force-pushed
the
statemutability-abi
branch
from
56a7881 to
1f5ab60
Compare
|
@chriseth check this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2722. Part of #992.