Ensure that library addresses supplied are of correct length and hex prefixed #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Feb 28, 2018
| @@ -337,16 +339,30 @@ Json::Value StandardCompiler::compileInternal(Json::Value const& _input) | |||
| return formatFatalError("JSONError", "library entry is not a JSON object."); | |||
| for (auto const& library: jsonSourceName.getMemberNames()) | |||
| { | |||
| string const& address = jsonSourceName[library].asString(); | |||
There was a problem hiding this comment.
Need to double check asString.
There was a problem hiding this comment.
does asString() really return a reference?
There was a problem hiding this comment.
No, it actually creates a new instance in some cases.
axic
changed the title
axic
commented
Mar 1, 2018
| { | ||
| char const* input = R"( | ||
| { | ||
| "language": "Solidity", | ||
| "settings": { | ||
| "libraries": { | ||
| "library.sol": { | ||
| "L": 42, | ||
| "L3": "42", | ||
| "L4": "0x42", |
chriseth
approved these changes
Mar 1, 2018
axic
force-pushed
the
jsonio-libraries-hex
branch
from
03f0246 to
8a86d20
Compare
…prefixed in JSONIO
axic
force-pushed
the
jsonio-libraries-hex
branch
from
8a86d20 to
b6dfd9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3617 and ethereum/solc-js#201