Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation and CLI help for --run parameter #4048

Merged
merged 1 commit into from
May 2, 2018
Merged

Improve documentation and CLI help for --run parameter #4048

merged 1 commit into from
May 2, 2018

Conversation

JonnyBurger
Copy link
Contributor

This was requested in #2245.

I have done the following:

  • Changed the --help text to explain what setting a high number for --run does.
  • Broken out the optimizer sentence into a separate paragraph and added documentation for the --run parameter.
  • In the example JSON config, I have added comments for --runs and changed 500 to 200 (the default).

Let me know if this is good!

@gitcoinbot gitcoinbot mentioned this pull request May 2, 2018
Closed
@chriseth
Copy link
Contributor

chriseth commented May 2, 2018

Wonderful, thanks!

@chriseth chriseth merged commit 42d6547 into ethereum:develop May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseth chriseth chriseth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonnyBurger @chriseth