Enable ecrecover tests on all forks #1177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about LegacyTests? |
I am not sure, but this worked well for our purposes. Any strong reason not to merge this? |
|
need to remove filled versions. rebase on the develop and fill again |
|
no reason no, everything for the devs. however if you need tests for all the networks like this there is a legacy tests subrepo there we have all the history vectors.\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The precompile has not changed since genesis, but many tests were only enabled starting a later fork (like London).
Note that some test can't be enabled before Byzantium because they use
staticcall.cc @gumb0 @chfast