Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file names and references #1390

Closed

Conversation

IaroslavMazur
Copy link
Contributor

Fixed the incorrect file names, as well as the references to them inside the other files in the repo.

@winsvega
Copy link
Collaborator

that require test regeneration. do you want me to do it?

@IaroslavMazur
Copy link
Contributor Author

that require test regeneration. do you want me to do it?

At this point, I don't (yet) know to do that, so, yes, please!

Also, it'd be awesome if you could briefly explain:

  • how the regeneration should be done
  • and why it's required in this case, in the first place 🙏🏻

@winsvega
Copy link
Collaborator

winsvega commented Jul 8, 2024

in this repo I track that test source filler files were used to generate the result test files.
if you change the filler, hash verification will fail.

@winsvega
Copy link
Collaborator

winsvega commented Jul 8, 2024

#1393

@winsvega winsvega closed this Jul 8, 2024
@IaroslavMazur
Copy link
Contributor Author

in this repo I track that test source filler files were used to generate the result test files. if you change the filler, hash verification will fail.

Thank you for regenerating the tests! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants