Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New v8.0.0-beta.1 Berlin HF release #692

Closed
wants to merge 1 commit into from

Conversation

holgerd77
Copy link
Contributor

@holgerd77 holgerd77 commented May 28, 2020

Now that #685 got merged I would like to directly continue with a first Berlin HF release after the preparatory final v7.0.0 release.

Then clients have a first basis and some comprise information to integrate on the subroutine tests. This might also help on foster reflection on additional edge and error cases.

@holgerd77 holgerd77 requested review from holiman and winsvega May 28, 2020 09:16
@holgerd77
Copy link
Contributor Author

//cc @matkt

@holiman
Copy link
Contributor

holiman commented May 28, 2020

Hold it :)
I just proposed some changes; ethereum/EIPs#2676 . It's implemented in geth already, should be fairly trivial for clients to update. We need to regenerate the testcases though :/

@holgerd77
Copy link
Contributor Author

@holiman No prob, already valuable to have this info collected here. Will wait until you give a go respectively update here then. 😄

@matkt
Copy link
Contributor

matkt commented May 28, 2020

I just added a new test for subroutines here #693 (not merged yet)

@holgerd77
Copy link
Contributor Author

@holiman Not completely followed all conversations, is the current develop branch with the merge of #693 now in a stable, consistent and correct state and also integrates correct tests for a final EIP-2315 version?

So would this be a good time to update here and do a release?

@winsvega
Copy link
Collaborator

winsvega commented Jun 5, 2020

For the release all tests should have Berlin generation. I am preparing an update for that.

@holgerd77
Copy link
Contributor Author

Ok

@holiman
Copy link
Contributor

holiman commented Jun 6, 2020 via email

@winsvega
Copy link
Collaborator

winsvega commented Jun 6, 2020

Regards to naming it is possible to assign any kind of name for the tests.
Then in a client configuration use actual name.

The reason we regeenrate all tests is to make sure that existing cases are not affected by new eips.
The same way it is possible to create tests for fork+eip rules.

@winsvega
Copy link
Collaborator

Wasn't it 7.0.0 release?

@holgerd77
Copy link
Contributor Author

@winsvega No, the current concept is to always have a major version bump for every major hardfork and v7.0.0 was the finalizing release of the "pre-Berlin era" 😄 , so on a Petersburg (and MuirGlacier) state.

The first v8 beta release introduces the Berlin release series ending up at some point in a stable v8 release with all finalized Berlin EIPs included (in our case with v7we were just pretty pretty late, maybe that's some source for confusion here).

@holgerd77
Copy link
Contributor Author

@winsvega Any updates on the Berlin test regeneration?

@winsvega
Copy link
Collaborator

winsvega commented Jun 19, 2020

No, only transition tool support. small test modifications.

Subroutines tests I see. No BLS12-381 curve operations was PR'ed

@holgerd77 holgerd77 mentioned this pull request Nov 24, 2020
@holgerd77
Copy link
Contributor Author

holgerd77 commented Feb 1, 2021

Hi guys, just as a pre-announcement: I will try to pick this up again this week or latest next week. 😄 To reiterate from what we've discussed on our call: then we can release this here as a major release v8.0.0 (so no beta any more) and you guys can pick up from there.

As some summary for @holiman and others: in the call with @qbzzt and @winsvega together with the JavaScript team we came to the conclusion that we want to move away from these HF-centric releases - which just turned out to not be practicable with these unpredictable HF dates - and instead do "normal" semantic versioning releases. So we simply do major releases every time there is a breaking change on the consumer (client developers) side, so e.g. a directory name change, a HF moved from "active" to "legacy", stuff like that. In this new scenario a new HF addition might become rather a minor release in the sense of a new feature added - at least if there is nothing breaking added along.

For us as a JavaScript team these releases are still important since they significantly help us to follow up with the changes on this repo and ensures a smooth upgrade process without breaking anything on our side. So it would be great if we are ending up with process of just doing regular releases evey 3-4 weeks or so, independent from the level of changes being done. Then we as a client team can easier follow-along and we will likely have shorter upgrade cycles.

Comments from representatives/other devs from other client teams highly welcome!

@holgerd77
Copy link
Contributor Author

Superseded by the latest releases, will close.

@holgerd77 holgerd77 closed this Feb 26, 2021
@winsvega winsvega deleted the new-release-v800-beta1 branch May 7, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants