Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1559 Readiness Tracking Issue #1257

Closed
4 tasks done
holgerd77 opened this issue May 17, 2021 · 3 comments
Closed
4 tasks done

EIP-1559 Readiness Tracking Issue #1257

holgerd77 opened this issue May 17, 2021 · 3 comments

Comments

@holgerd77
Copy link
Member

holgerd77 commented May 17, 2021

This is a tracking issue for the EIP-1559 implementation being done in #1148 and eventual follow-up PRs to make sure all spec changes, open issues and bugs as well as discovered inconsistencies are addressed before a final release.

TODOs

  • Block: Decide on BaseFee default value Block: EIP-1559 BaseFee Default Value #1250 and add implementation
  • Tx: Update EIP1559Transaction.toJSON() method attribute names with final RPC spec naming (link?)
  • Block: Update BlockHeader.toJSON() method attribute names with final RPC spec naming (link?)

Release

  • Add note to access list API being experimental
@jochem-brouwer
Copy link
Member

JSON RPC PR

@jochem-brouwer
Copy link
Member

jochem-brouwer commented May 22, 2021

Dumping some stuff I found at the 1559 review (will edit this comment)

BaseTransaction validates r/s max int, 2930 does this also in the constructor.

2930 uses yParity, 1559 uses v.

@holgerd77
Copy link
Member Author

Initial release is done - see #1263 - subsequent adoptions or fixes will likely be done in dedicated PRs susequently, will close here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants