-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
London Releases #1263
London Releases #1263
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Ok, I am done with a first round on the This PR can already be reviewed though to decouple and slowly get ready, think the vast majority of this should be stable. |
|
||
EIP-1559 blocks have an extra `baseFeePerGas` field (default: `new BN(7)`) and can encompass `FeeMarketEIP1559Transaction` txs (type `2`) (supported by `@ethereumjs/tx` `v3.2.0` or higher) as well as `Transaction` legacy txs (internal type `0`) and `AccessListEIP2930Transaction` txs (type `1`). | ||
|
||
## Consensus Types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff here looks a bit strange, better to be viewed as a complete file.
…pdated README, updated upstream dependency versions
…dated upstream dependency versions
…ed README, updated upstream dependency versions
…ed README, updated upstream dependency versions
…y, updated README, updated upstream dependency versions
90ef195
to
1694c69
Compare
Ok, I have addressed all review requests from @jochem-brouwer on my additional changes on #1048, hopefully sufficient, for some I have opened somewhat extensive new issues. Have also done a last I would pledge for an early release here, tomorrow (Wednesday) or even still today (not sure if realistic). If we still release early in the week ecosystem devs would be able to eventually already start experimenting and integrating this week, this wouldn't be the case any more if we release on Thursday or Friday. And I think this would be an important week to gain at this stage. We could then continue at some relaxed and solid pace and eventually do another round of releases in two weeks or so with some eventually necessary last fixes or tweaks. Then the final I we start now with running some last minute tests against some open 1559 branches from there I think the chance (risk) is high that we get caught up into some hastily fix discussions where failures might even be triggered by tests not being finalized. And for our mainly dev-centric user audience I would judge this more important to get people have their hands on testing the base functionality and start integrating than us double-ensuring that we have fixed the last very edgy bug. Ok, if you go along with this arguments I would be happy on some approval here. 🙂 If not drop a note. 😋 |
Update: if you have last change requests to the release PR itself please directly update the PR! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR prepares
london
compatible releases on the following libraries:@ethereumjs/common
@ethereumjs/tx
@ethereumjs/block
@ethereumjs/blockchain
@ethereumjs/vm