Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

London Releases #1263

Merged
merged 11 commits into from
May 27, 2021
Merged

London Releases #1263

merged 11 commits into from
May 27, 2021

Conversation

holgerd77
Copy link
Member

This PR prepares london compatible releases on the following libraries:

  • @ethereumjs/common
  • @ethereumjs/tx
  • @ethereumjs/block
  • @ethereumjs/blockchain
  • @ethereumjs/vm

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #1263 (90ef195) into master (a1e7a34) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 90ef195 differs from pull request most recent head 1694c69. Consider uploading reports for the commit 1694c69 to get more accurate results
Impacted file tree graph

Flag Coverage Δ
block 86.20% <ø> (ø)
blockchain 84.42% <ø> (+0.06%) ⬆️
client 84.95% <ø> (ø)
common 88.12% <ø> (ø)
devp2p 84.07% <ø> (ø)
ethash 82.08% <ø> (ø)
tx 89.06% <ø> (ø)
vm 86.71% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member Author

holgerd77 commented May 20, 2021

Ok, I am done with a first round on the london release PR. 😄
(of course this can be updated on necessary final tweaks and fixes)

This PR can already be reviewed though to decouple and slowly get ready, think the vast majority of this should be stable.
🦀 🐠 🐡


EIP-1559 blocks have an extra `baseFeePerGas` field (default: `new BN(7)`) and can encompass `FeeMarketEIP1559Transaction` txs (type `2`) (supported by `@ethereumjs/tx` `v3.2.0` or higher) as well as `Transaction` legacy txs (internal type `0`) and `AccessListEIP2930Transaction` txs (type `1`).

## Consensus Types
Copy link
Member Author

@holgerd77 holgerd77 May 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff here looks a bit strange, better to be viewed as a complete file.

@holgerd77
Copy link
Member Author

@ryanio thanks for the updates here! 😄

Rebased this and added a note on #1264

@holgerd77
Copy link
Member Author

Ok, I have addressed all review requests from @jochem-brouwer on my additional changes on #1048, hopefully sufficient, for some I have opened somewhat extensive new issues.

Have also done a last baikal sync (up to block 37.000) without issues. I would therefore now put this in final review. 😄

I would pledge for an early release here, tomorrow (Wednesday) or even still today (not sure if realistic). If we still release early in the week ecosystem devs would be able to eventually already start experimenting and integrating this week, this wouldn't be the case any more if we release on Thursday or Friday. And I think this would be an important week to gain at this stage.

We could then continue at some relaxed and solid pace and eventually do another round of releases in two weeks or so with some eventually necessary last fixes or tweaks. Then the final ethereum/tests releases should also be out and it should be possible to run the libraries against the final test suite.

I we start now with running some last minute tests against some open 1559 branches from there I think the chance (risk) is high that we get caught up into some hastily fix discussions where failures might even be triggered by tests not being finalized.

And for our mainly dev-centric user audience I would judge this more important to get people have their hands on testing the base functionality and start integrating than us double-ensuring that we have fixed the last very edgy bug.

Ok, if you go along with this arguments I would be happy on some approval here. 🙂

If not drop a note. 😋

@holgerd77
Copy link
Member Author

Update: if you have last change requests to the release PR itself please directly update the PR! Thanks!

Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@holgerd77 holgerd77 merged commit 366bf4f into master May 27, 2021
@holgerd77 holgerd77 deleted the london-releases branch May 27, 2021 07:14
@holgerd77
Copy link
Member Author

Just published the following releases on npm:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants