EIP2718/EIP2930 clean branch #1133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common: ensure that EIPs enforce required EIPs are active
tx: introduce EIP2930Transaction
tx: small EIP2930Transaction fixes
tx: fix transactionFactory build
tx: extend base class with common methods tx: fix tests
tx: fix undefined v/r/s/yParity values
tx: fix eip2930 not throwing on wrong chain id
tx: add yParity test tx: fix chainId check for big numbers
tx: set default TxOpts value
tx: allow either buffers or json-types for access lists
tx: run new tests by default tx: fix hash(), raw() of EIP2930Transaction tx: fix EIP2930 hash scheme
package: lint tx: fix tests and run linter tx: fix EIP2930 signatures/serialization/hash tx: fix tests
vm: add support for EIP2930 vm: add EIP2930-specific test
vm: setup EIP2930 tests
tx: fix browser tests vm: state tests to use EIP2930
vm/tx/block: add changelog tx: add some docs tx: check s value OK, make json-tx geth compatible common: remove empty test vm: remove unnecesary comment
…test clean-up, add more tests tx -> EIP-2930: fixed missing toBuffer conversion for v value in EIP2930Transaction constructor tx -> EIP-2930: added generic API tests for serialize() and raw() tx -> EIP-2930: added generic verifySignature() tests tx -> EIP-2920: added generic verifySignature() error test cases tx -> EIP-2930: small test fix
…blicKey(), verifySignature() tests
tx: add fromSerializedTx method tx: remove TODOs tx: add fromSerializedTx to legacy transaction
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
4 tasks
|
Will stop here for today, fixing CI should be rather easy I think, it is good to see that the difference between this one (+2055, -492) is almost the same as the original (+2054, -500). |
jochem-brouwer
force-pushed
the
eip2718-eip2930-clean
branch
from
b98f7a6 to
00ec7a5
Compare
tx: move api test to legacy test tx: lint
jochem-brouwer
force-pushed
the
eip2718-eip2930-clean
branch
from
00ec7a5 to
9c6f2f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just creating this PR to run the CIs, will probably fail, was a lengthy rebase process. Will close this one when tests passes and then force push to #1048.