Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx: De-sszify 4844 blob transaction #2708

Merged
merged 7 commits into from
May 22, 2023
Merged

tx: De-sszify 4844 blob transaction #2708

merged 7 commits into from
May 22, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented May 17, 2023

@g11tech g11tech added PR state: WIP package: tx target: master Work to be done towards master branch labels May 17, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #2708 (fd28041) into master (3f2cd73) will increase coverage by 0.00%.
The diff coverage is 81.51%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.75% <ø> (+0.28%) ⬆️
blockchain 90.72% <ø> (ø)
client 86.95% <0.00%> (-0.03%) ⬇️
common 97.05% <ø> (ø)
devp2p 89.47% <ø> (+0.07%) ⬆️
ethash ∅ <ø> (∅)
evm 79.31% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 80.92% <ø> (ø)
trie 89.94% <ø> (ø)
tx 95.76% <83.09%> (-0.26%) ⬇️
util 81.34% <ø> (ø)
vm 81.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

I'm on it. 🙂

Do we still have SSZ usage somewhere or could/should we also remove the Util dependency for now? 😬

(since we have the code we can easily re-add later once this is introduced)

@g11tech
Copy link
Contributor Author

g11tech commented May 22, 2023

I'm on it. slightly_smiling_face

Do we still have SSZ usage somewhere or could/should we also remove the Util dependency for now? grimacing

(since we have the code we can easily re-add later once this is introduced)

sounds good, as per discord discussion will do a followup PR removing ssz as for now we don't need it anywhere and can re-add whenever required 🙂

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit dd8afc5 into master May 22, 2023
@holgerd77 holgerd77 deleted the 4844-tx-rlp branch May 22, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants