-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run with the latest tests (ethereumjs-testing v1.2.1) #348
Conversation
First results: Byzantium: Constantinople: |
792ed1c
to
a69bf82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have now added the one failing test case to the broken tests list, since no one seems to have the time to fix atm and we need the updated tests to be able to continue with the constantinople implementation.
Will merge.
@@ -14,7 +14,8 @@ const skipBroken = [ | |||
'TransactionCollisionToEmptyButCode', // temporary till fixed (2017-09-21) | |||
'TransactionCollisionToEmptyButNonce', // temporary till fixed (2017-09-21) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see how these temporary things go 😝
This PR runs the VM on the latests tests, I've done a new
ethereumjs-testing
v1.2.1 release, also added some CHANGELOG entry on the updates on the testing repository.I will close #305, since this brings not enough value with minimal changes and three commits to rebase this and bring this in order.
We can nevertheless reference this here for going back to the notes already done on some test results.