Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream paritytech/bn #26

Merged
merged 2 commits into from
Jul 21, 2018
Merged

Use upstream paritytech/bn #26

merged 2 commits into from
Jul 21, 2018

Conversation

axic
Copy link
Member

@axic axic commented Jul 17, 2018

Fixes #16.

Depends on #23.

Needs a rebuilt asm.js to be pushed to this PR.

@axic axic requested review from hugo-dc and cdetrio July 17, 2018 00:10
@cdetrio
Copy link
Contributor

cdetrio commented Jul 17, 2018

If there are issues building this (for both asm.js and wasm), it may be due to rustc-serialize, see ewasm/bn@4332319

edit: nevermind, rustc-serialize is removed in #30

@axic
Copy link
Member Author

axic commented Jul 17, 2018

This PR on its own builds fine also, because upstream made rustc-serialise optional (and it is disabled here).

Copy link
Contributor

@hugo-dc hugo-dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, successfully compiles and pass all tests

@hugo-dc hugo-dc merged commit 0a4a831 into master Jul 21, 2018
@axic axic deleted the use-upstream branch July 21, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants