This repository has been archived by the owner on Oct 4, 2019. It is now read-only.
[ECIP-1029] Include uncles in total difficulty calculation (GHOST) #334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ECIP-1029 for more information.
Note that while the GHOST protocol is published a long time ago and has been advertised to be used by Ethereum, due to the sort-of design flaw, it is actually never used by any well-known cryptocurrencies. Thus what I suggest is that we test this PR on a testnet first, make sure it runs stable, before taking measures to merge ECIP-1029 and incorporate this soft-fork into other clients.
The actual change is small while can impact some critical aspect of the consensus.
TODO:
63
using the old total difficulty meaning.