Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rats nest linking on Windows OS #1346

Closed
wants to merge 1 commit into from
Closed

Fix rats nest linking on Windows OS #1346

wants to merge 1 commit into from

Conversation

manoj398
Copy link

This fixes the issue which is caused in windows.

found the solution from here nodejs/node#18518 (comment)

@manoj398
Copy link
Author

I am using node 14.5 btw. I don't know the exact cause for this issue. Hope this fix doesn't effect other OS.

@ricmoo ricmoo changed the title fixes #1345 Fix rats nest linking on Windows OS Apr 16, 2021
@ricmoo ricmoo added bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published. labels Apr 18, 2021
@ricmoo
Copy link
Member

ricmoo commented Apr 18, 2021

This should be fixed in the master branch now. Try it out and let me know.

Thanks! :)

@ricmoo
Copy link
Member

ricmoo commented Apr 23, 2021

Closing, but if you still have any issues, please re-open.

Thanks! :)

@ricmoo ricmoo closed this Apr 23, 2021
pull bot pushed a commit to shapeshift/ethers.js that referenced this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants